Skip to content

Add SecurityContext to delegating TaskScheduler #9532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add SecurityContext to delegating TaskScheduler #9532

wants to merge 1 commit into from

Conversation

@gbaso
Copy link
Contributor

@gbaso gbaso commented Mar 31, 2021

Wrap DelegatingSecurityContextTaskScheduler's Runnable tasks in
DelegatingSecurityContextRunnables, allowing to specify a
SecurityContext to use for tasks execution.

Closes gh-9514

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 31, 2021
@gbaso gbaso mentioned this pull request Mar 31, 2021
Closed
jzheaux
jzheaux requested changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @gbaso! I've left some feedback inilne.

@jzheaux jzheaux self-assigned this Apr 5, 2021
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 5, 2021
jzheaux
jzheaux requested changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @gbaso! I've left some additional feedback inline.

@gbaso gbaso requested a review from jzheaux April 14, 2021 12:52
jzheaux
jzheaux requested changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @gbaso!

Thanks for your descriptive commit messages. To simplify maintenance, will you please squash your commits into a single atomic commit?

@gbaso
Add SecurityContext to delegating TaskScheduler
cc97a2c 
Wrap DelegatingSecurityContextTaskScheduler's Runnable tasks in
DelegatingSecurityContextRunnables, allowing to specify a
SecurityContext to use for tasks execution.

- Renamed private variable taskScheduler to delegate
- Removed unused local variable in unit test
- Add SecurityContext tests for delegating TaskScheduler

Closes spring-projectsgh-9514
@gbaso
Copy link
Contributor Author

gbaso commented Apr 16, 2021

@jzheaux PR should be ready now

@jzheaux jzheaux added this to the 5.6.0-M1 milestone Apr 21, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Apr 21, 2021

Thanks, @gbaso! I've scheduled this for 5.6.0-M1.

@jzheaux
Copy link
Contributor

jzheaux commented Jun 7, 2021

Thanks again, @gbaso! This is now merged into main via 80743a2. I also added a small polish to add the @since attribute to the new constructor's JavaDoc via e1e3193

@jzheaux jzheaux closed this Jun 7, 2021
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Jun 7, 2021
@gbaso gbaso deleted the gh-9514 branch June 14, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzheaux jzheaux jzheaux requested changes

Assignees

@jzheaux jzheaux

Labels

in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Milestone

5.6.0-M1

Development

Successfully merging this pull request may close these issues.

DelegatingSecurityContextTaskScheduler does not allow to use a specific SecurityContext

3 participants

@gbaso @jzheaux @spring-projects-issues